[
https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822502#comment-16822502
]
Chunwei Lei commented on CALCITE-2453:
--------------------------------------
{quote}The first statement is parsed successfully and the second one failed.
Should we keep result of the first statement? Or should we consider it as a
failure?
{quote}
Sorry, I change my idea. I think it is better to consider it as a failure when
meeting an error statement which seems more reasonable.
Besides, I find PR#783 is not as good as expected since it treats some negative
test cases as success wrongly. For instance, the following sql
{code:java}
select * from emp where name like 'toto'; delete from emp; delete from emp
select * from dept
{code}
will be parsed successfully. As a result, I opened a new pull request:
[https://github.com/apache/calcite/pull/1177|https://github.com/apache/calcite/pull/1177/].
The major changes in the new PR are as follows:
* Correct the wrong definition in the .jj file
* Add some negative test cases
* Resolve conflicts
> Enhance the SQL parser in order to optionally support semicolon at the end of
> the sql statements
> ------------------------------------------------------------------------------------------------
>
> Key: CALCITE-2453
> URL: https://issues.apache.org/jira/browse/CALCITE-2453
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: next
> Reporter: charbel yazbeck
> Assignee: Chunwei Lei
> Priority: Trivial
> Labels: pull-request-available
> Attachments:
> 0001-CALCITE-2453-Allowing-SQL-statements-to-optionally-e.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Consists of adding [<SEMICOLON>] in Parser.jj
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
