[
https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837930#comment-16837930
]
Julian Hyde commented on CALCITE-2282:
--------------------------------------
[~danny0405], I reviewed your PR. It looks basically good. There is some
complicated logic in SqlIdentifier and SqlUtil. Do you think that logic could
be re-organized into a boolean function that says whether to quote the
identifier? Then the code that generates SQL can remain basically unchanged.
> Allow OperatorTable to be pluggable in the parser
> -------------------------------------------------
>
> Key: CALCITE-2282
> URL: https://issues.apache.org/jira/browse/CALCITE-2282
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Sudheesh Katkam
> Priority: Major
> Labels: pull-request-available
> Attachments: CALCITE-2282.patch.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SqlAbstractParserImpl [hardcodes OperatorTable to
> SqlStdOperatorTable|https://github.com/apache/calcite/blob/8327e674e7f0a768d124fa37fd75cda4b8a35bb6/core/src/main/java/org/apache/calcite/sql/parser/SqlAbstractParserImpl.java#L334|https://github.com/apache/calcite/blob/8327e674e7f0a768d124fa37fd75cda4b8a35bb6/core/src/main/java/org/apache/calcite/sql/parser/SqlAbstractParserImpl.java#L334].
> Make this pluggable via a protected method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
