[
https://issues.apache.org/jira/browse/CALCITE-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829168#comment-16829168
]
Ruben Quesada Lopez edited comment on CALCITE-3021 at 5/14/19 7:37 AM:
-----------------------------------------------------------------------
[~julianhyde], did you get a chance to take a look at the new test in the PR?
was (Author: rubenql):
[~julianhyde], did you get a chance to take a look at the new test in the PR?
> ArrayEqualityComparer should use Arrays#deepEquals/deepHashCode instead of
> Arrays#equals/hashCode
> -------------------------------------------------------------------------------------------------
>
> Key: CALCITE-3021
> URL: https://issues.apache.org/jira/browse/CALCITE-3021
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.19.0
> Reporter: Ruben Quesada Lopez
> Assignee: Ruben Quesada Lopez
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, ArrayEqualityComparer (which is used as comparer for
> JavaRowFormat.ARRAY) performs the array comparison based on Arrays#equals and
> Arrays#hashCode (see Functions.java):
> {code:java}
> private static class ArrayEqualityComparer implements
> EqualityComparer<Object[]> {
> public boolean equal(Object[] v1, Object[] v2) {
> return Arrays.equals(v1, v2);
> }
> public int hashCode(Object[] t) {
> return Arrays.hashCode(t);
> }
> }
> {code}
> This will lead to incorrect comparisons in case of multidimensional arrays,
> e.g. a row (array) with a struct field (another array) inside. To fix the
> issue, Arrays#deepEquals / Arrays#deepHashCode should be used:
> {code:java}
> private static class ArrayEqualityComparer implements
> EqualityComparer<Object[]> {
> public boolean equal(Object[] v1, Object[] v2) {
> return Arrays.deepEquals(v1, v2);
> }
> public int hashCode(Object[] t) {
> return Arrays.deepHashCode(t);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
