[ https://issues.apache.org/jira/browse/CALCITE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839731#comment-16839731 ]
Julian Hyde commented on CALCITE-2913: -------------------------------------- I made an initial quick pass (didn't look at the code, just the overall structure): * Yes, I'd like this module to be part of Calcite. * Make sure to respect Kafka's branding. Each page in the documentation where Kafka is mentioned, the first mention should call it "Apache Kafka". I'd change the name of this case/commit to "Adapter for Apache Kafka". * In a couple of places (pom.xml and adapter.md) there is a list of modules/adapters; you've put kafka at the end, but it should be in alphabetical order. * Maybe I missed it, but is there a docker image or other method by which a release manager can do a quick smoke test, i.e. run a test that really talks to Kafka. > add a KafkaAdapter for Stream > ----------------------------- > > Key: CALCITE-2913 > URL: https://issues.apache.org/jira/browse/CALCITE-2913 > Project: Calcite > Issue Type: New Feature > Components: core > Reporter: Xu Mingmin > Priority: Major > Labels: pull-request-available > Time Spent: 7h 40m > Remaining Estimate: 0h > > Add a new adapter which exposes a Kafka topic into a Stream table, we've one > version in our env and would like to share it if not duplicated. > Hint, we are actually extending it as a batch table, limiting to Stream table > sounds more straight-forward to me as 1st step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)