[ https://issues.apache.org/jira/browse/CALCITE-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851254#comment-16851254 ]
Julian Hyde commented on CALCITE-2742: -------------------------------------- Reviewing PR 1031 now it has been rebased. One question: is the "Optional" stuff necessary? We can assume that USER and SYSTEM_USER are set in DataContext, right? I don't like over-defensive programming. > Update RexImpTable to user DataContext to retrieve USER and SYSTEM_USER > ----------------------------------------------------------------------- > > Key: CALCITE-2742 > URL: https://issues.apache.org/jira/browse/CALCITE-2742 > Project: Calcite > Issue Type: Improvement > Reporter: Jacques Nadeau > Assignee: Jacques Nadeau > Priority: Major > Labels: pull-request-available > Time Spent: 5h 20m > Remaining Estimate: 0h > > Right now, USER and SYSTEM_USER are hardcoded to "sa" and the system property > of user.name. Let's update them to use the DataContext system like the other > similar types of values. -- This message was sent by Atlassian JIRA (v7.6.3#76005)