[ https://issues.apache.org/jira/browse/CALCITE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853512#comment-16853512 ]
Julian Hyde commented on CALCITE-2944: -------------------------------------- I'm working in this code right now. If you haven't started, may I fix it? > Deprecate Aggregate indicators and remove fields where possible > --------------------------------------------------------------- > > Key: CALCITE-2944 > URL: https://issues.apache.org/jira/browse/CALCITE-2944 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Haisheng Yuan > Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > Attachments: image-2019-03-21-18-19-58-933.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Although Aggregate.indicator is discouraged to use, but no test cases > guarantee indicator can work correctly. I tried to set indicator to always > false in Aggregate constructor, it passed all the tests. > !image-2019-03-21-18-19-58-933.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)