[
https://issues.apache.org/jira/browse/CALCITE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-2944.
----------------------------------
Resolution: Fixed
A follow-up commit
[b0e83c46|https://github.com/apache/calcite/commit/b0e83c469ff57257c1ea621ff943ca76f626a9b7]
deprecates all APIs that have a {{boolean indicator}} parameter, changes them
to throw if {{indicator == true}}, and switches all internal code to use the
new APIs.
> Deprecate Aggregate indicators and remove fields where possible
> ---------------------------------------------------------------
>
> Key: CALCITE-2944
> URL: https://issues.apache.org/jira/browse/CALCITE-2944
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Attachments: image-2019-03-21-18-19-58-933.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Although Aggregate.indicator is discouraged to use, but no test cases
> guarantee indicator can work correctly. I tried to set indicator to always
> false in Aggregate constructor, it passed all the tests.
> !image-2019-03-21-18-19-58-933.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
