[ 
https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854037#comment-16854037
 ] 

Julian Hyde commented on CALCITE-3065:
--------------------------------------

{{getJavaClass}} is a specialized piece of code only for purposes where we are 
implementing a plan as java code (i.e. enumerable convention). It does not 
apply to the whole type system, which applies also to plans that are 
implemented by generating SQL to be sent over JDBC, or generating Druid plans, 
or whatever.

There are many cases where the representation of a literal in generated java 
code is not the same as the representation inside a {{RexLiteral}}.

So, the behavior of {{getJavaClass}} doesn't prove anything. You can't use it 
to justify changes to the behavior of {{RexLiteral}}.

> RexLiteral#getValueAs should consider primitive type
> ----------------------------------------------------
>
>                 Key: CALCITE-3065
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3065
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jiatao Tao
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2019-05-13-12-04-36-365.png, 
> image-2019-05-17-08-23-52-735.png, image-2019-06-02-08-15-35-460.png, 
> image-2019-06-02-08-43-51-646.png
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> !image-2019-05-13-12-04-36-365.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to