[ 
https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854165#comment-16854165
 ] 

Jiatao Tao edited comment on CALCITE-3065 at 6/3/19 2:52 AM:
-------------------------------------------------------------

Hi

[~julianhyde] truly thanks for your explanation.

Seems the name "getJavaClass" is a little confusing, it only does a little 
thing, not a universal API.

And in my opinion, an API that can get class from "RelDataType" is useful, so 
that I can easily get the true value from RexLiteral though getValueAs.

 

And seems that the value that "RexLiteral.getValueAs" returns are all nullable, 
it may diff from its ori type.


was (Author: aron.tao):
Hi

[~julianhyde] truly thanks for your explanation.

Seems the name "getJavaClass" is a little confusing, it only does a little 
thing, not a universal API.

 

And seems that the value that "RexLiteral.getValueAs" returns are all 
nullable(although we can get this from SqlType).

> RexLiteral#getValueAs should consider primitive type
> ----------------------------------------------------
>
>                 Key: CALCITE-3065
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3065
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jiatao Tao
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2019-05-13-12-04-36-365.png, 
> image-2019-05-17-08-23-52-735.png, image-2019-06-02-08-15-35-460.png, 
> image-2019-06-02-08-43-51-646.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> !image-2019-05-13-12-04-36-365.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to