[ https://issues.apache.org/jira/browse/CALCITE-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884252#comment-16884252 ]
Khai Tran commented on CALCITE-3122: ------------------------------------ [~julianhyde]: Fixed all issues except 3 following: * "Can you make {{RelOptCluster.planner}} final again?" -> discussed above * "Do we need {{PigRelBuilder}} and {{LogicalPigRelBuilder}} to be separate classes?" -> we should merge them into one, but PigRelBuilder is in core and LogicalPigRelBuilder is in piglet. I think we should move the merged code into piglet. As PigRelBuilder is not my code and I'm not sure if that affects anyone? * "{{ToLogicalConverter}} would be more robust and flexible if you used a {{RelBuilder}} rather than calling {{RelNode.create}} methods explicitly" -> RelBuilder is not powerful enough to create all nodes needed for the conversion. I tried but giving up in the middle as it's ugly to use both ways at the same time. Please let me know how you want to go for those options. I will fix them in the next round. > Convert Pig Latin scripts into Calcite logical plan > ---------------------------------------------------- > > Key: CALCITE-3122 > URL: https://issues.apache.org/jira/browse/CALCITE-3122 > Project: Calcite > Issue Type: New Feature > Components: core, piglet > Reporter: Khai Tran > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > We create an internal Calcite repo at LinkedIn and develop APIs to parse any > Pig Latin scripts into Calcite logical plan. The code was tested in nearly > ~1000 Pig scripts written at LinkedIn. > Changes: > 1. piglet: main conversion code live there, include: > * APIs to convert any Pig scripts into RelNode plans or SQL statements > * Use Pig Grunt parser to parse Pig Latin scripts into Pig logical plan > (DAGs) > * Convert Pig schemas into RelDatatype > * Traverse through Pig expression plan and convert Pig expressions into > RexNodes > * Map some basic Pig UDFs to Calcite SQL operators > * Build Calcite UDFs for any other Pig UDFs, including UDFs written in both > Java and Python > * Traverse (DFS) through Pig logical plans to convert each Pig logical nodes > to RelNodes > * Have an optimizer rule to optimize Pig group/cogroup into Aggregate > operators > 2. core: > * Implement other RelNode in Rel2Sql so that Pig can be translated into SQL > * Other minor changes in a few other classes to make Pig to Calcite works -- This message was sent by Atlassian JIRA (v7.6.14#76016)