[ 
https://issues.apache.org/jira/browse/CALCITE-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908526#comment-16908526
 ] 

Haisheng Yuan commented on CALCITE-3089:
----------------------------------------

+1 on the tweaks, which make more sense to call {{splitJoinCondition}} directly 
when creating {{JoinInfo}}. Yes, we should deprecate 
{{org.apache.calcite.rel.core.EquiJoin}}. I may forget doing it, because that 
is the intent of this JIRA.

> Deprecate EquiJoin
> ------------------
>
>                 Key: CALCITE-3089
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3089
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Haisheng Yuan
>            Assignee: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> EquiJoin should be replaced by Join with equiConds and nonEquiConds (empty if 
> it doesn't have).
> EquiJoin will not have any subclasses. EnumerableHashJoin and 
> EnumerableMergeJoin, SemiJoin should extend Join directly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to