[
https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915397#comment-16915397
]
feng huang commented on CALCITE-3282:
-------------------------------------
Hi [~danny0405], actually, i didn't get you, why i should have a default
implementation to unparse the Cast operator in SqlDialect#unparseCall, in my
opinion, a default implementation in SqlDialect#unparseDataType which invokes
unparse logic in SqlTypeNameSpec is better. Not only it follow the past unpase
logic, but also we can extend SqlDialect and override unparseDataType to
implement specific logic about datatype.
> Make every SqlDialect unparse their own data type
> -------------------------------------------------
>
> Key: CALCITE-3282
> URL: https://issues.apache.org/jira/browse/CALCITE-3282
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: feng huang
> Priority: Minor
>
> Every database might have different type or same type but different type
> name, therefore making every SqlDialect unparse their own data type is a
> suitable way.
> For example, there is a sql “select cast(col as int) from table” change to
> hive sql "select cast(col as integer) from table", but "integer" is not
> allowed in hive.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
