[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916709#comment-16916709 ]
Danny Chan commented on CALCITE-3244: ------------------------------------- [~vvysotskyi] I have applied a patch to fix the decorrelation. But with the fix, there is a breaking test in misc.iq#L709, the original test passes because just because it can not decorrelate values expression, if the change the values to project, the test still fails, so i think this is another fix and should fire the fix in another issue. > RelDecorrelator unable to decorrelate expression with filter and aggregate on > top > --------------------------------------------------------------------------------- > > Key: CALCITE-3244 > URL: https://issues.apache.org/jira/browse/CALCITE-3244 > Project: Calcite > Issue Type: Improvement > Affects Versions: 1.20.0 > Reporter: benj > Assignee: Danny Chan > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Some very useful type of requests currently failed with: > {code:java} > SYSTEM ERROR: UnsupportedOperationException: Adding Implicit RowID column is > not supported for ValuesPrel operator > {code} > Examples from DRILL-7050: > {code:sql} > select t1.id, > (select count(t2.id) > from ( > select 1 as id > union all > select 2 as id > ) t2 where t2.id = t1.id) > from ( > select 1 as id > union all > select 2 as id > ) t1 > {code} > {code:sql} > SELECT t, > (SELECT count(*) FROM > (SELECT split(r,' ') AS r FROM > (SELECT sub.t AS r)) AS x > ,LATERAL(SELECT $unnest AS u FROM unnest(x.r)) > /* WHERE ... */) t2 > FROM > (SELECT 'unnest is useful' AS t) sub > {code} > > _Please note that in 1.18 the error for these requests was:_ > {code:java} > Error: PLAN ERROR: Cannot convert RexNode to equivalent Drill expression. > RexNode Class: org.apache.calcite.rex.RexCorrelVariable, RexNode Digest: $cor0 > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)