[ https://issues.apache.org/jira/browse/CALCITE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928911#comment-16928911 ]
Rui Wang commented on CALCITE-3340: ----------------------------------- Actually by the idea above(with a slight modification), I was able to quickly prototype to pass validator and generate a logical plan as the following string format: {code:java} LogicalProject(ROWTIME=[$0], ID=[$1], PRODUCT=[$2], UNITS=[$3], wstart=[$4], wend=[$5]) LogicalTableFunctionScan(invocation=[TUMBLE_TABLE_FUNCTION($3, 60000:INTERVAL MINUTE)], rowType=[RecordType(TIMESTAMP(0) ROWTIME, INTEGER ID, VARCHAR(10) PRODUCT, INTEGER UNITS, TIMESTAMP(0) wstart, TIMESTAMP(0) wend)]) {code} Apparently there should be LogicalProject generated as an input for LogicalTableFunctionScan, which I will further investigate. I feel like it's a good progress so far. LogicalTableFunctionScan has a return type with two new fields appended: wstart and wend > Make TUMBLE be accepted as an operand for COLLECTION_TABLE(TABLE syntax) in > validator > ------------------------------------------------------------------------------------- > > Key: CALCITE-3340 > URL: https://issues.apache.org/jira/browse/CALCITE-3340 > Project: Calcite > Issue Type: Sub-task > Reporter: Rui Wang > Assignee: Rui Wang > Priority: Major > > For query: > SELECT * > FROM TABLE(TUMBLE( > TABLE ORDERS, > DESCRIPTOR(ROWTIME), > INTERVAL '10' MINUTE)) > (note reuse TUMBLE operator than use a new unresolved one) > Calcite validator will does a step to do registration and > "TABLE(TUMBLE(...))" will hit [1], where "TUMBLE(...)" will be passed to [2] > again but there is no matching Sqlkind handling for "TUMBLE" (note that > TUMBLE's node kind is TUMBLE). > It seems we should support TUMBLE in [2]. The details of how to support it > needs a bit more discussion and prototyping. > [1]: > https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2244 > [2]:https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2031 -- This message was sent by Atlassian Jira (v8.3.2#803003)