[ 
https://issues.apache.org/jira/browse/CALCITE-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940615#comment-16940615
 ] 

xzh_dz edited comment on CALCITE-3290 at 9/30/19 2:59 AM:
----------------------------------------------------------

@[~julianhyde] 

different implement.

In my implement,the AbstractNode subclass can call evalute() method directly 
rather than call  Expressions.evaluate(Node node).

Such as BinaryExpression :   BinaryExpression.evaluate(),not need to bring 
parameter.

How do you think about it ? Thank you.


was (Author: xzh_dz):
@[~julianhyde] 

different implement.

> evaluate in AbstractNode
> ------------------------
>
>                 Key: CALCITE-3290
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3290
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: xzh_dz
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> we could implement the expressions evaluate in AbstractNode directly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to