[ 
https://issues.apache.org/jira/browse/CALCITE-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963441#comment-16963441
 ] 

Haisheng Yuan commented on CALCITE-3458:
----------------------------------------

Correct, toString() and getDescription() are only called when trace is enabled. 
So no need for benchmark.

> Remove desc in AbstractRelNode
> ------------------------------
>
>                 Key: CALCITE-3458
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3458
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> If the query is super large, e.g. contains tens of thousands of nodes or 
> expressions, the RelNode digest and desc become very large. The content of 
> desc and digest are almost the same, except that desc consists of id plus 
> digest, which causes OOM in our production system. So remove desc, just use 
> {{id + digest}} to produce description.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to