[ 
https://issues.apache.org/jira/browse/CALCITE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967094#comment-16967094
 ] 

Steven Talbot commented on CALCITE-3475:
----------------------------------------

Linked a proposed fix in [https://github.com/apache/calcite/pull/1559]

> BigQuery SQL dialect unparseCall override broken for UNION ALL
> --------------------------------------------------------------
>
>                 Key: CALCITE-3475
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3475
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Steven Talbot
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.22.0
>
>
> The break on line 
> [https://github.com/apache/calcite/blob/ff43dcb95caa251e5fc8120980fc70c8fea8ac40/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L134]
>  should be inside the if. Otherwise, UNION ALL does not trigger the if, hits 
> the `break`, and then nothing is unparsed at all!
>  
> From looking at the code, INTERSECT and EXCEPT would seem to have the same 
> problem, except per BQ syntax specification at 
> [https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#set-operators],
>  the "ALL" is not supported with either of those, so it may not matter (but 
> the code may want to explicitly blow up, saying that those aren't supported?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to