[ https://issues.apache.org/jira/browse/CALCITE-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986050#comment-16986050 ]
Ruben Q L edited comment on CALCITE-3535 at 12/2/19 4:34 PM: ------------------------------------------------------------- Based on my previous comments, I committed {{@Ignore}} to {{UtilTest#testRelBuilderExample}} to see how it impacted CI tests, this is the result compared to the original PR: *Original PR* |Github CI Windows (JDK 8)|stuck| |Github CI Linux (JDK 11)|stuck| |Github CI macOS (JDK 13)|stuck| |AppVeyor (Windows JDK8 & 11)|stuck| |Travis (Ubuntu JDK 8 & 11)|OK| *UtilTest#testRelBuilderExample Ignored* |Github CI Windows (JDK 8)|OK| |Github CI Linux (JDK 11)|stuck| |Github CI macOS (JDK 13)|stuck| |AppVeyor (Windows JDK 8 & 11)|OK| |Travis (Ubuntu JDK 8 & 11)|OK| So it seems that the problem is not just UtilTest#testRelBuilderExample ? was (Author: rubenql): Based on my previous comments, I committed {{@Ignore}} to {{UtilTest#testRelBuilderExample}} to see how it impacted CI tests, this is the result compared to the original PR: *Original PR* |Github CI Windows (JDK 8)|stuck| |Github CI Linux (JDK 11)|stuck| |Github CI macOS (JDK 13)|stuck| |AppVeyor (Windows JDK8 & 11)|stuck| |Travis (Ubuntu JDK 8 & 11)|OK| *UtilTest#testRelBuilderExample Ignored* |Github CI Windows (JDK 8)|OK| |Github CI Linux (JDK 11)|stuck| |Github CI macOS (JDK 13)|stuck| |AppVeyor (Windows JDK 8 & 11)|waiting...| |Travis (Ubuntu JDK 8 & 11)|OK| So it seems that the problem is not just UtilTest#testRelBuilderExample > EnumerableJoinRule: remove unnecessary Filter on top of INNER Join > ------------------------------------------------------------------ > > Key: CALCITE-3535 > URL: https://issues.apache.org/jira/browse/CALCITE-3535 > Project: Calcite > Issue Type: Task > Components: core > Affects Versions: 1.21.0 > Reporter: Ruben Q L > Assignee: Ruben Q L > Priority: Minor > Labels: pull-request-available > Fix For: 1.22.0 > > Attachments: threadDump.txt > > Time Spent: 20m > Remaining Estimate: 0h > > With the implementation of CALCITE-2973, now EnumerableHashJoin supports all > type of conditions (not just equi joins). However, there is still one > [TODO|https://github.com/apache/calcite/blob/07c1efbb2b42a0e27f9d01968d357d9c1e17cd51/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoinRule.java#L89] > in EnumerableHashJoinRule that, in case of an INNER Join, creates a Filter > with the non-equi conditions on top of the EnumerableHashJoin (created only > with the equi-conditions), this filter is not really needed, since now > EnumerableHashJoinRule can support the full condition: equi and non-equi > items. -- This message was sent by Atlassian Jira (v8.3.4#803005)