[ https://issues.apache.org/jira/browse/CALCITE-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Haisheng Yuan updated CALCITE-3756: ----------------------------------- Description: Even RelSubset is a subclass of RelNode, but they are quite different. RelNode already fires these rules, it is not necessary to fire for RelSubset. More importantly, it never worked due to CALCITE-3755. In addition, it will waste time to try to iterate class operands of RelSubset and try to match pattern operand(RelNode), given that it never matches when ascending. was: Even RelSubset is a subclass of RelNode, but they are quite different. RelNode already fires these rules, it is not necessary to fire fore RelSubset. More importantly, it never worked due to CALCITE-3755. In addition, it will waste time to try to iterate class operands of RelSubset and try to match pattern operand(RelNode), given that it never matches when ascending. > RelSubset should not match operand(RelNode.class) > ------------------------------------------------- > > Key: CALCITE-3756 > URL: https://issues.apache.org/jira/browse/CALCITE-3756 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: Haisheng Yuan > Priority: Major > > Even RelSubset is a subclass of RelNode, but they are quite different. > RelNode already fires these rules, it is not necessary to fire for RelSubset. > More importantly, it never worked due to CALCITE-3755. > In addition, it will waste time to try to iterate class operands of RelSubset > and try to match pattern operand(RelNode), given that it never matches when > ascending. -- This message was sent by Atlassian Jira (v8.3.4#803005)