[ https://issues.apache.org/jira/browse/CALCITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated CALCITE-3807: ------------------------------------ Labels: pull-request-available (was: ) > checkForSatisfiedConverters() is unnecessary > --------------------------------------------- > > Key: CALCITE-3807 > URL: https://issues.apache.org/jira/browse/CALCITE-3807 > Project: Calcite > Issue Type: Bug > Reporter: Xiening Dai > Priority: Major > Labels: pull-request-available > > When VolcanoPlanner registers an abstract converter, it adds the converter > into set.abstractConverters list, then calls checkSatisfiedConverter() to see > if any converter is satisfied and can be remove from the list. But for every > abstract converter, it always satisfies itself (changeTraitsUsingConverters() > returns itself). Basically the converter would be removed from the list right > after it's added. So this check is completely unnecessary and it slows down > the planner. -- This message was sent by Atlassian Jira (v8.3.4#803005)