[
https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073434#comment-17073434
]
Julian Hyde commented on CALCITE-3892:
--------------------------------------
All code benefits from having tight access control - no more visible than it
needs to be. Even if not published in jars.
If we don't make this change, people will continue making test classes and
methods public, due to cargo culting.
> Make junit test classes and methods non-public
> ----------------------------------------------
>
> Key: CALCITE-3892
> URL: https://issues.apache.org/jira/browse/CALCITE-3892
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Priority: Major
>
> In junit 4 and earlier versions, junit classes and methods must be public. In
> junit 5 (jupiter) this is no longer the case.
> This change makes classes and methods package-protected where possible (i.e.
> removes the "public" modifier). It makes tests a bit more concise, and gives
> us more freedom to refactor tests in future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
