[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085402#comment-17085402 ]
Danny Chen commented on CALCITE-3932: ------------------------------------- We compare our types in many places with `==` in our code, so the cached types should never be weak or soft references [1] [1] https://github.com/apache/calcite/blob/2798d90a8082adb294c3aadbad6d22d9228abf3e/core/src/main/java/org/apache/calcite/plan/RelOptUtil.java#L2184 > Make data type cache thread local, non-evictable > ------------------------------------------------ > > Key: CALCITE-3932 > URL: https://issues.apache.org/jira/browse/CALCITE-3932 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Haisheng Yuan > Priority: Major > > Data type can be evicted out of cache, which is global, thread-safe. > It seems not necessary to cache them globally, because most of them are > RelRecordType, which is query dependent, not sharable between different > queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)