[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093850#comment-17093850
 ] 

Julian Hyde edited comment on CALCITE-2970 at 4/27/20, 7:12 PM:
----------------------------------------------------------------

bq. Also sub-classing RelBuilder may not be a good idea, but it's been there 
for some time. MaxCompute, Flink and other adapters are already doing that...

That doesn't make it right. It's not supported. We may break them. Tough.

There are times when I'd love to have sub-classed {{java.lang.String}}. I can't.


was (Author: julianhyde):
bq. Also sub-classing RelBuilder may not be a good idea, but it's been there 
for some time. MaxCompute, Flink and other adapters are already doing that...

That doesn't make it right. It's not supported. We may break them. Tough.

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to