[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108738#comment-17108738 ]
Haisheng Yuan commented on CALCITE-4003: ---------------------------------------- I am not objecting multiple-convention rules, but none of built-in transformation rules can work correctly for multi-convention, except those with a converter in-between, like ProjectTableScanRule, or ProjectMergeRule, which will always generate logical project, make it nothing different with only matching logical projects. > In MaterializationTest, FilterProjectTransposeRule matches with logical and > physical convention > ----------------------------------------------------------------------------------------------- > > Key: CALCITE-4003 > URL: https://issues.apache.org/jira/browse/CALCITE-4003 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Haisheng Yuan > Priority: Major > > In MaterializationTest.testMaterializationSubstitution2, > FilterProjectTransposeRule matches with logical and physical convention at > the same time, that means, LogicalFilter and EnumerableProject. We should > check and prevent this from happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)