[ https://issues.apache.org/jira/browse/CALCITE-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113469#comment-17113469 ]
Julian Hyde commented on CALCITE-4018: -------------------------------------- Could this summary be improved, to be more useful to the person reading the release notes? The current summary describes a code change (or a task), not a feature. How about changing 'Implement trait propagation for EnumerableValues' to 'EnumerableValues should provide requested traits', or similar. Also add an example that motivates the change. > Implement trait propagation for EnumerableValues > ------------------------------------------------- > > Key: CALCITE-4018 > URL: https://issues.apache.org/jira/browse/CALCITE-4018 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Haisheng Yuan > Priority: Major > > Only passThrough is needed. > Currently, when Values is created, it will enumerate all the possible > collations no matter parent operator requires it or not, it will be a > disaster if the Values has thousands of columns, and the parent operator may > be just a hash aggregate or hashjoin, which doesn't care about its collation. > The collation should be created on demand by calling passThrough. -- This message was sent by Atlassian Jira (v8.3.4#803005)