[ 
https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165254#comment-17165254
 ] 

Julian Hyde commented on CALCITE-4079:
--------------------------------------

[~rubenql], I'll add {{List<RexNode> Sort.getSortExps()}}. The list will be 
computed on demand, rather populated in Sort's constructor.

> Dialect constants in SqlDialect can cause class initialization deadlock
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-4079
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4079
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.23.0
>            Reporter: TANG Wen-hui
>            Assignee: Julian Hyde
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.25.0
>
>         Attachments: CALCITE-4079.01.patch, 
> image-2020-07-01-19-27-25-354.png, image-2020-07-01-19-51-32-397.png
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {code:java}
> /** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect DUMMY =
>     AnsiSqlDialect.DEFAULT;
> /** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect CALCITE =
>     CalciteSqlDialect.DEFAULT;{code}
> SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be 
> used in any places.
> It would be better to remove them to avoid class initialization deadlock.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to