[ 
https://issues.apache.org/jira/browse/CALCITE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173453#comment-17173453
 ] 

Julian Hyde commented on CALCITE-4155:
--------------------------------------

Does your fix only work on IN (e.g. "x IN (1, 2)") or does it also work on the 
expanded form ("x = 1 OR x = 2")? I think it is important that we handle both, 
and do it in this PR. 

If we don't do it now, I think the code will forever diverge.

> Simplify IN expression of discrete values
> -----------------------------------------
>
>                 Key: CALCITE-4155
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4155
>             Project: Calcite
>          Issue Type: New Feature
>          Components: core
>            Reporter: Liya Fan
>            Assignee: Liya Fan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For example, given expressions like
> {{a in (1, 2, 3, 4, 5)}}
> or
> {{a = 1 or a = 2 or a = 3 or a = 4 or a = 5}},
> we can simplify it to
> {{a >= 1 and a <= 5}}
> Such simplification reduces the number of value comparisons from 5 to 2. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to