[ 
https://issues.apache.org/jira/browse/CALCITE-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189692#comment-17189692
 ] 

Vladimir Sitnikov commented on CALCITE-4214:
--------------------------------------------

Just a note: I think I would keep the existing 
{{org.apache.calcite.rel.type.RelDataTypeImpl#getSqlTypeName}} method even 
though it is {{return null}}.

For now, I add javadoc that sub-classes must override the method (which is 
always the case for the current core)

> Make RelDataType.getSqlTypeName non-nullable
> --------------------------------------------
>
>                 Key: CALCITE-4214
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4214
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The code treated RelDataType.getSqlTypeName as non-nullable, so we need to 
> update the javadoc and deal with abstract implementation that returns null.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to