[
https://issues.apache.org/jira/browse/CALCITE-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195626#comment-17195626
]
Julian Hyde commented on CALCITE-4253:
--------------------------------------
Yeah, it's not great. If you read the comments on
{{RelOptCluster.getMetadataQuery()}} you'll see it's discouraged.
[~jcamachorodriguez], Do you recall why, in CALCITE-1682, you moved the code
into {{RelMetadataQuery}} (creating {{RelMetadataQuery.getNodeTypes}} in the
process). Maybe you needed caching or extensibility?
> RelOptUtil#findAllTables should probably use
> RelMetadataQuery#getTableReferences
> --------------------------------------------------------------------------------
>
> Key: CALCITE-4253
> URL: https://issues.apache.org/jira/browse/CALCITE-4253
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.25.0
> Reporter: Vladimir Sitnikov
> Priority: Minor
>
> It looks like both methods do exactly the same thing, so it would probably
> make sense to divert {{findAllTables}} to
> {{RelMetadataQuery#getTableReferences}}
> If methods are different, it would make sense to add the relevant
> documentation and cross-references.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
