[ 
https://issues.apache.org/jira/browse/CALCITE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206812#comment-17206812
 ] 

Julian Hyde commented on CALCITE-3782:
--------------------------------------

[~hailong wang], Since you implemented this feature, I think you should 
research the specification and write tests for corner cases. I know that 
{{BIT_AND(X'FF', X'')}} currently returns {{X'FF'}}, and that is wrong.

The code treats empty ByteString values are special, and I don't see any good 
reason for that.

> Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-3782
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3782
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> According to the discussion  link CALCITE-3732 , We should make bitwise 
> operators work on all integer types, BINARY and VARBINARY. So Bit_And, Bit_OR 
> and Bit_XOR agg operator should also support BINARY and VARBINARY.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to