[ https://issues.apache.org/jira/browse/CALCITE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324630#comment-17324630 ]
Julian Hyde commented on CALCITE-4583: -------------------------------------- The system is already configurable in many, many ways. (RelBuilder.Config.simplify(); RexSimplifier.simplifyFilterPredicates vs. simplifyUnknownAsFalse; predicates; executor; Hook.REL_BUILDER_SIMPLIFY; config.bloat() which controls how project expressions are combined with underlying expressions). Can you figure out a way to rationalize, not add yet another knob for people to set wrong? Reading the javadoc you have written, it is not even obvious how I "turn simplify on". > Make simplification controllable in "RelBuilder#filter" > ------------------------------------------------------- > > Key: CALCITE-4583 > URL: https://issues.apache.org/jira/browse/CALCITE-4583 > Project: Calcite > Issue Type: Improvement > Components: core > Reporter: Jiatao Tao > Assignee: Jiatao Tao > Priority: Critical > Labels: pull-request-available > Attachments: image-2021-04-15-20-52-15-757.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Previous in CALCITE-2338, we make simplification configurable in most methods > except RelBuilder#filter, this Jira aims to cover this method. -- This message was sent by Atlassian Jira (v8.3.4#803005)