[ 
https://issues.apache.org/jira/browse/CALCITE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324654#comment-17324654
 ] 

Jiatao Tao edited comment on CALCITE-4583 at 4/19/21, 2:55 AM:
---------------------------------------------------------------

[~julianhyde] TBH, I don't think I add any knob, just align with these.

When I set "config.simplify()" to false, RelBuilder#project/RelBuilder#join 
will not call the RexSimplify, but RelBuilder#filter still. It makes no sense.

!image-2021-04-19-10-45-21-768.png|width=453,height=452!

!image-2021-04-19-10-45-48-287.png|width=456,height=356!


was (Author: aron.tao):
TBH, I don't think I add any Just align with these

!image-2021-04-19-10-45-21-768.png|width=453,height=452!

!image-2021-04-19-10-45-48-287.png|width=456,height=356!

> Make "RelBuilder#filter" to be configurable by "RelBuilder.Config#simplify()"
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-4583
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4583
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Critical
>              Labels: pull-request-available
>         Attachments: image-2021-04-15-20-52-15-757.png, 
> image-2021-04-19-10-45-21-768.png, image-2021-04-19-10-45-48-287.png
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Previous in CALCITE-2338, we make simplification configurable in most methods 
> except RelBuilder#filter, this Jira aims to cover this method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to