[ 
https://issues.apache.org/jira/browse/CALCITE-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiatao Tao updated CALCITE-4586:
--------------------------------
    Description: 
Hi, in PigRelBuilder#create, we set Hook.REL_BUILDER_SIMPLIFY to false:
 
 {{}}
 
I have two doubts:
1. Why we set FALSE here cuz its default value is true;
2. This maybe not the suitable place to set  "Hook.REL_BUILDER_SIMPLIFY", IMO 
we should use this in user code, not in the frame code, cuz once we done this 
in frame code, we can not change this config anymore.

> In piglet, allow creating a PigRelBuilder with custom "config.simplify()"
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-4586
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4586
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Critical
>             Fix For: 1.27.0
>
>
> Hi, in PigRelBuilder#create, we set Hook.REL_BUILDER_SIMPLIFY to false:
>  
>  {{}}
>  
> I have two doubts:
> 1. Why we set FALSE here cuz its default value is true;
> 2. This maybe not the suitable place to set  "Hook.REL_BUILDER_SIMPLIFY", IMO 
> we should use this in user code, not in the frame code, cuz once we done this 
> in frame code, we can not change this config anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to