[ 
https://issues.apache.org/jira/browse/CALCITE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350867#comment-17350867
 ] 

Julian Hyde commented on CALCITE-4608:
--------------------------------------

I tried to reproduce this with the following patch against 
[b7e90e1a|https://github.com/apache/calcite/commit/b7e90e1aeead1406855030023c7dc1934f821cc6],
 but no luck:
{noformat}
diff --git a/server/src/test/resources/sql/table.iq 
b/server/src/test/resources/sql/table.iq
index 54f814a0a..7de50d72c 100755
--- a/server/src/test/resources/sql/table.iq
+++ b/server/src/test/resources/sql/table.iq
@@ -215,4 +215,19 @@ drop table if exists t;
 
 !update
 
+create table t (x int, y float) as values (1, 1.5), (2, 14.33);
+(0 rows modified)
+
+!update
+select * from t where y < 1.7976931348623157E308;
++---+-------+
+| X | Y     |
++---+-------+
+| 1 |   1.5 |
+| 2 | 14.33 |
++---+-------+
+(2 rows)
+
+!ok
+
 # End table.iq
{noformat}

> Fix NullPointerException in SqlNumericLiteral.isInteger()
> ---------------------------------------------------------
>
>                 Key: CALCITE-4608
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4608
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.26.0
>            Reporter: Amrish Lal
>            Assignee: Ruben Q L
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> In 1.26, a NullPointerException is thrown in SqlNumericLiteral.isInteger(), 
> due to "this.scale" being null. This can be reproduced by compiling SQL 
> statement "SELECT * FROM testTable WHERE floatColumn > 
> 1.7976931348623157E308".
> A null check was added through CALCITE-4199 to fix the NullPointerException; 
> however, the root cause is that scale and precision are not being properly 
> set in {{SqlLiteral.createApproxNumeric}} function which is called to handle 
> {{APPROX_NUMERIC_LITERAL}} token.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to