[ https://issues.apache.org/jira/browse/CALCITE-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397698#comment-17397698 ]
Julian Hyde commented on CALCITE-4726: -------------------------------------- On reflection, I think that adding {{SqlAggFunction.ignoresNullsByDefault}} should be a separate JIRA case. If you decide to do that work, do it as a separate commit, and we can associate with a JIRA case number later. All commits can be in the same PR. > Add support for filters in AggregateExpandWithinDistinctRule > ------------------------------------------------------------ > > Key: CALCITE-4726 > URL: https://issues.apache.org/jira/browse/CALCITE-4726 > Project: Calcite > Issue Type: Improvement > Reporter: Will Noble > Priority: Blocker > > Currently, {{AggregateExpandWithinDistinctRule}} does not fire if any of the > aggregate calls in the aggregate have a filter. We should support filters. > For example, the following query will not be handled by the current rule due > to the {{FILTER}} clause: > {code:java} > SELECT deptno, > SUM(sal), > SUM(sal) WITHIN DISTINCT (job) FILTER (WHERE ename LIKE 'A%') > FROM emp > GROUP BY deptno > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)