[ 
https://issues.apache.org/jira/browse/CALCITE-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458056#comment-17458056
 ] 

Julian Hyde commented on CALCITE-4935:
--------------------------------------

I vote for 1 (yes). The goal is a standalone server in a single jar, and a 
standalone server will include some form of logging. Probably the logging 
doesn't even need to be shaded.

If someone wants a more complicated project (e.g. pulling in some other 
libraries, which may or may not have their own logging) then they can build 
their own project with their own make file.

If we are agreed on 1, do we need to make any changes to 1.20.0 RC 0?

> Avatica standalone-server shades log4j without relocation
> ---------------------------------------------------------
>
>                 Key: CALCITE-4935
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4935
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>             Fix For: avatica-1.20.0
>
>         Attachments: screenshot-1.png
>
>
> The issue has been found during the vote for avatica-1.20.0 RC0.
> The standalone-server jar in the [staged maven 
> repository|https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/avatica/avatica-standalone-server/1.20.0/avatica-standalone-server-1.20.0.jar]
>  contains log4j2 classes but they are not relocated. 
> In previous, Avatica versions (e.g., avatica-1.19.0), log4j classes were all 
> relocated to avoid classpath problems with other libraries/apps potentially 
> using another log4j2 version.
> It seems that relocation was dropped in possibly unintenionally in 
> CALCITE-4152.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to