[ https://issues.apache.org/jira/browse/CALCITE-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ioan Eugen Stan updated CALCITE-4966: ------------------------------------- Summary: In class CsvEnumerator, the inner class RowConverter should be public (was: org.apache.calcite.adapter.file.CsvEnumerator.RowConverter should be public) > In class CsvEnumerator, the inner class RowConverter should be public > --------------------------------------------------------------------- > > Key: CALCITE-4966 > URL: https://issues.apache.org/jira/browse/CALCITE-4966 > Project: Calcite > Issue Type: Bug > Components: file-adapter > Reporter: Ioan Eugen Stan > Priority: Minor > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Hello, > I believe class org.apache.calcite.adapter.file.CsvEnumerator.RowConverter > should be public instead of package private since it's exposed in the public > api via > public constructor: > {code:java} > public CsvEnumerator(Source source, AtomicBoolean cancelFlag, boolean stream, > @Nullable String @Nullable [] filterValues, RowConverter<E> rowConverter) > { {code} > public static method: > {code:java} > public static RowConverter<@Nullable Object[]> arrayConverter( > List<RelDataType> fieldTypes, List<Integer> fields, boolean stream) { > return new ArrayRowConverter(fieldTypes, fields, stream); > } {code} > > Patch is trivial, add "public" in front :) > {code:java} > public abstract static class RowConverter<E> { {code} > Would love to get this into 1.29.0 - so I can make a surprise for Calcite :D -- This message was sent by Atlassian Jira (v8.20.1#820001)