[
https://issues.apache.org/jira/browse/CALCITE-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520109#comment-17520109
]
xiong duan commented on CALCITE-5027:
-------------------------------------
[~julianhyde] As mentioned in PR. This method is only used in SqlBuilder for
the purposes of creating SQL queries and expressions with String. So can't add
a SQL test about this. So welcome to review.
> Incorrect format for timestamp literals
> ---------------------------------------
>
> Key: CALCITE-5027
> URL: https://issues.apache.org/jira/browse/CALCITE-5027
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Gregory Hart
> Assignee: xiong duan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.31.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The SqlDialect#quoteTimestampLiteral method uses the wrong format for
> standard SQL. Instead of "day of month" it uses "day of year", and instead of
> seconds is uses milliseconds. To fix this method, the format should be
> changed to:
> yyyy-MM-dd HH:mm:ss
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
