[ https://issues.apache.org/jira/browse/CALCITE-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536853#comment-17536853 ]
Julian Hyde commented on CALCITE-5061: -------------------------------------- I had a quick look at [~rubenql]'s PR and it looks great. > Improve recursive application of the field trimming > --------------------------------------------------- > > Key: CALCITE-5061 > URL: https://issues.apache.org/jira/browse/CALCITE-5061 > Project: Calcite > Issue Type: Improvement > Reporter: Thomas Rebele > Assignee: Ruben Q L > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The RelFieldTrimmer has some shortcomings: > * If the plan contains certain set ops (e.g., UNION(all=false)), even if the > operator needs all fields for the correct result (CALCITE-3399), it may still > make sense to apply the trimming to the children. See CALCITE-5051 for an > example. > * Same applies for a Sort with dynamic parameters in the fetch/offset, and > RepeatUnions > * The makeZeroLiteral logic in trimChildRestore(...) does not work for ARRAY > / Java types. -- This message was sent by Atlassian Jira (v8.20.7#820007)