[
https://issues.apache.org/jira/browse/CALCITE-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604861#comment-17604861
]
Krzysztof Ślusarski edited comment on CALCITE-5285 at 9/14/22 5:12 PM:
-----------------------------------------------------------------------
Suppose you have a rule that converts your
{color:#172b4d}{{LogicalCalc}}{color} to other {{{}rel{}}}. Example from
Hazelcast:
[https://github.com/hazelcast/hazelcast/blob/master/hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/opt/logical/CalcLogicalRule.java]
That rule is on the queue in
{{org.apache.calcite.plan.volcano.IterativeRuleDriver > ruleQueue > matchList >
queue}} during {{{}org.apache.calcite.tools.Programs.RuleSetProgram#run{}}}.
Next step is tu run {{CalcReduceExpressionsRule#onMatch}} which transforms to
the same rule (with new id). The rule that is already in the {{queue}} will not
be executed since the old {{LogicalCalc}} is pruned. Everything would be ok if
a new rule would be added to the queue. That happens in
{{org.apache.calcite.plan.volcano.VolcanoPlanner#registerImpl}} while executing
{{{}fireRules(rel);{}}}. This line unfortunately cannot be reached because that
part of code returns from method first:
{code:java}
RelSet equivSet = getSet(equivExp);
if (equivSet != null) {
LOGGER.trace(
"Register: rel#{} is equivalent to {}", rel.getId(), equivExp);
return registerSubset(set, getSubsetNonNull(equivExp));
} {code}
I will try to generate a test.
was (Author: JIRAUSER295689):
Suppose you have a rule that converts your
{color:#172b4d}{{LogicalCalc}}{color} to your {{{}rel{}}}. Example from
Hazelcast:
[https://github.com/hazelcast/hazelcast/blob/master/hazelcast-sql/src/main/java/com/hazelcast/jet/sql/impl/opt/logical/CalcLogicalRule.java]
That rule is on the queue in
{{org.apache.calcite.plan.volcano.IterativeRuleDriver > ruleQueue > matchList >
queue}} during {{{}org.apache.calcite.tools.Programs.RuleSetProgram#run{}}}.
Next step is tu run {{CalcReduceExpressionsRule#onMatch}} which transforms to
the same rule (with new id). The rule that is already in the {{queue}} will not
be executed since the old {{LogicalCalc}} is pruned. Everything would be ok if
a new rule would be added to the queue. That happens in
{{org.apache.calcite.plan.volcano.VolcanoPlanner#registerImpl}} while executing
{{{}fireRules(rel);{}}}. This line unfortunately cannot be reached because that
part of code returns from method first:
{code:java}
RelSet equivSet = getSet(equivExp);
if (equivSet != null) {
LOGGER.trace(
"Register: rel#{} is equivalent to {}", rel.getId(), equivExp);
return registerSubset(set, getSubsetNonNull(equivExp));
} {code}
I will try to generate a test.
> CalcReduceExpressionsRule may transform to same rel
> ---------------------------------------------------
>
> Key: CALCITE-5285
> URL: https://issues.apache.org/jira/browse/CALCITE-5285
> Project: Calcite
> Issue Type: Bug
> Components: server
> Reporter: Krzysztof Ślusarski
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.33.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Method {{CalcReduceExpressionsRule#onMatch}} enters the branch and calculates
> {{reduceExpressions()}} condition. If that one is true it creates new calc.
> Unfortunately logic in {{reduceExpressions()}} is different then in the rest
> of the method and it can create a calc that is equal to the input.
> Example query {{{}SELECT floor(this / 1) FROM test{}}}.
> Input calc contains program with exprs:
> {{0 = \{RexInputRef@11348} "$0"}}
> {{1 = \{RexInputRef@11349} "$1"}}
> {{2 = \{RexCall@11350} "CAST($t1):BIGINT(32)"}}
> {{3 = \{RexLiteral@11351} "1:BIGINT(32)"}}
> {{4 = \{RexCall@11352} "/($t2, $t3)"}}
> {{5 = \{RexCall@11353} "FLOOR($t4)"}}
> The one on index 4 can be simplified (the division can be removed). That
> condition is met in {{{}reduceExpressions(){}}}, but following logic in
> {{onMatch()}} doesn't simplify that expression.
> This makes the output calc equals to input one which breaks the rest of query
> optimizing.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
