[ https://issues.apache.org/jira/browse/CALCITE-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606775#comment-17606775 ]
TJ Banghart edited comment on CALCITE-5269 at 9/19/22 9:30 PM: --------------------------------------------------------------- Opened [https://github.com/apache/calcite/pull/2913] but it is not as complete as I had hoped. In hindsight it would have made more sense to start with some of the other issues in the parent ticket. I noted the following and will create issues for them shortly (in no particular order): 1) Support for BQ DATETIME literals and functions needs to happen before `DATETIME_TRUNC` can be supported. 2) Postgres-like `DATE_TRUNC` function calls have a slightly different syntax and are more flexible than the BQ style `DATE_TRUNC`. Need to be careful when updating the core parser to prefer one over the other. For example: {code:java} DATE_TRUNC(<string>, <timestamp | date | time>) vs DATE_TRUNC(<date>, <interval>){code} 3) Missing support for ISOWEEK interval. 4) Missing support for ISOYEAR for standard FLOOR implementation. was (Author: tjbanghart): Opened [https://github.com/apache/calcite/pull/2913] but it is not as complete as I had hoped. In hindsight it would have made more sense to start with some of the other issues in the parent ticket. I noted the following and will create issues for them shortly (in no particular order): 1) Support for BQ DATETIME literals and functions needs to happenĀ before `DATETIME_TRUNC` can be supported 2) Postgres-like `DATE_TRUNC` function calls have a slightly different syntax and are more flexible than the BQ style `DATE_TRUNC`. Need to be careful when updating the core parser to prefer one over the other. For example: {code:java} DATE_TRUNC(<string>, <timestamp | date | time>) vs DATE_TRUNC(<date>, <interval>){code} 3) Missing support for ISOWEEK interval 4) Missing support for ISOYEAR for standard FLOOR implementation > Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions > ----------------------------------------------------------- > > Key: CALCITE-5269 > URL: https://issues.apache.org/jira/browse/CALCITE-5269 > Project: Calcite > Issue Type: Sub-task > Reporter: TJ Banghart > Assignee: TJ Banghart > Priority: Major > > Implement missing BigQuery functions for: > * TIME_TRUNC > * TIMESTAMP_TRUNC -- This message was sent by Atlassian Jira (v8.20.10#820010)