shampoo liu created CALCITE-5348: ------------------------------------ Summary: The defaultNullCollation configuration can't take effect for over Key: CALCITE-5348 URL: https://issues.apache.org/jira/browse/CALCITE-5348 Project: Calcite Issue Type: Bug Components: core Affects Versions: 1.32.0 Reporter: shampoo liu Attachments: image-2022-10-26-20-38-36-332.png
The convertSortExpression in SqlToRelConverter.convertOver was changed to bb::sortToRex and the bb::sortToRex didn't read validator().config().defaultNullCollation() !image-2022-10-26-20-38-36-332.png! [https://github.com/apache/calcite/blob/c945b7f49b99538748c871557f6ac80957be2b6e/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2247] Also, the test case can't check the NullCollation in over at org.apache.calcite.test.SqlToRelConverterTest#testUserDefinedOrderByOver -- This message was sent by Atlassian Jira (v8.20.10#820010)