[ 
https://issues.apache.org/jira/browse/CALCITE-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

shampoo liu updated CALCITE-5348:
---------------------------------
    Description: 
The connection configuration  string defaultNullCollation=LOW can't take effect 
for order by in over clause. 

After debug, I found that the  convertSortExpression in 
SqlToRelConverter.convertOver was changed to bb::sortToRex and the 
bb::sortToRex didn't read default configuration.

[https://github.com/apache/calcite/blob/c945b7f49b99538748c871557f6ac80957be2b6e/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2247]

 

Also, The test case can't check the NullCollation in over at  
org.apache.calcite.test.SqlToRelConverterTest#testUserDefinedOrderByOver 

 

  was:
The connection  string defaultNullCollation=LOW can't take effect for order by 
in over clause. 

After debug, I found that the  convertSortExpression in 
SqlToRelConverter.convertOver was changed to bb::sortToRex and the 
bb::sortToRex didn't read validator().config().defaultNullCollation()

[https://github.com/apache/calcite/blob/c945b7f49b99538748c871557f6ac80957be2b6e/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2247]

 

Also, the test case can't check the NullCollation in over at  
org.apache.calcite.test.SqlToRelConverterTest#testUserDefinedOrderByOver 

 


> The defaultNullCollation configuration can't take effect for over
> -----------------------------------------------------------------
>
>                 Key: CALCITE-5348
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5348
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.32.0
>            Reporter: shampoo liu
>            Priority: Major
>
> The connection configuration  string defaultNullCollation=LOW can't take 
> effect for order by in over clause. 
> After debug, I found that the  convertSortExpression in 
> SqlToRelConverter.convertOver was changed to bb::sortToRex and the 
> bb::sortToRex didn't read default configuration.
> [https://github.com/apache/calcite/blob/c945b7f49b99538748c871557f6ac80957be2b6e/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2247]
>  
> Also, The test case can't check the NullCollation in over at  
> org.apache.calcite.test.SqlToRelConverterTest#testUserDefinedOrderByOver 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to