[ 
https://issues.apache.org/jira/browse/CALCITE-5352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626680#comment-17626680
 ] 

Julian Hyde commented on CALCITE-5352:
--------------------------------------

You are both correct. Calcite is consistent with the standard. DATE_PART is 
useful and widely used, and we should fully support it, including the form 
where the first argument is a character literal.

[~carton], Are there any similar datetime functions that Calcite does not 
support correctly?

I would welcome a PR but only after I have completed and merged CALCITE-5155. A 
PR submitted before then would require a difficult rebase.

> Babel parser does not recogize quote string with DATE_PART function
> -------------------------------------------------------------------
>
>                 Key: CALCITE-5352
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5352
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: carton.swing
>            Priority: Major
>
> While using babel parser(calcite-babel's SqlBabelParserImpl) to parse 
> PostgreSQL syntax:
> {code:java}
> planner.parse("SELECT DATE_PART('week', TIMESTAMP '2022-10-31')"){code}
> it will throws exception.
> But if I use:
> {code:java}
> planner.parse("SELECT DATE_PART(week, TIMESTAMP '2022-10-31')"){code}
> the parser works well.
>  
> However, the former syntax, which is a quote-string, is correct according to 
> : [https://www.postgresql.org/docs/9.1/functions-datetime.html]
> |Note that here the {{field}} parameter needs to be a string value, not a 
> name. The valid field names for {{date_part}} are the same as for 
> {{{}extract{}}}.
> SELECT date_part('day', TIMESTAMP '2001-02-16 20:38:40');|
> The first argument should be a quote string instead of a TimeUnit token.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to