[
https://issues.apache.org/jira/browse/CALCITE-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680407#comment-17680407
]
Julian Hyde commented on CALCITE-5381:
--------------------------------------
Making a {{private static}} method into a {{protected}} method - what is done
in PR 3043 - is not great. {{RelBuilder}} cannot safely be extended by
subclassing.
I think the way to go here is to add a config parameter.
{{RelBuilder.Config.withSimplifyLimit(boolean)}} (added in CALCITE-4209 to
disable an undesired 'optimization') is a good model to follow.
The PR must have a unit test in {{RelBuilderTest}}.
> Add configuration via property to turn on/off check if correlated in
> RelBuilder
> -------------------------------------------------------------------------------
>
> Key: CALCITE-5381
> URL: https://issues.apache.org/jira/browse/CALCITE-5381
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Sergey Nuyanzin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The issue is that the change done in
> https://issues.apache.org/jira/browse/CALCITE-4668 is not supported now in
> Flink and requires some significant efforts to make it working.
> At the same time we would like to move forward with Calcite update.
> Currently there is no way to turn this off via property e.g. or via
> overriding of methods.
> This jira issues proposes introducing such property (turn on by default)
> turning off means Calcite 1.27.0 behavior
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
