[ 
https://issues.apache.org/jira/browse/CALCITE-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703563#comment-17703563
 ] 

Julian Hyde commented on CALCITE-5599:
--------------------------------------

Trigonometric functions are fairly common among DBs, and are likely to have the 
same specification. So I'd be inclined to enable them by default, not add them 
to a particular library.

If the PRs are small, submit several functions as one PR (and Jira case).

You probably don't need to create a class for each function; 
{{SqlBasicFunction.create}} works pretty well.

> Support more trigonometric functions for BigQuery
> -------------------------------------------------
>
>                 Key: CALCITE-5599
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5599
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Zou
>            Assignee: Zou
>            Priority: Major
>
> We have already supported many trigonometric functions in calcite, such as 
> SIN, COS, and there are still some trigonometric functions in BigQuery not 
> supported:
>  * ACOSH(X):Computes the inverse hyperbolic cosine of X.
>  * COTH(X): Computes the hyperbolic cotangent for the angle of {{{}X{}}}, 
> where {{X}} is specified in radians.
>  * CSC(X): Computes the cosecant of the input angle, which is in radians.
>  * CSCH(X): Computes the hyperbolic cosecant of the input angle, which is in 
> radians.
>  * SEC(X): Computes the secant for the angle of {{{}X{}}}, where {{X}} is 
> specified in radians. 
>  * SECH(X): Computes the hyperbolic secant for the angle of {{{}X{}}}, where 
> {{X}} is specified in radians.
> More info could be found in [BigQuery 
> Doc|https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#acosh]
> This is an umbrella issue, and I will create subtasks for each function 
> listed above later.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to