[ https://issues.apache.org/jira/browse/CALCITE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728849#comment-17728849 ]
Julian Hyde edited comment on CALCITE-5722 at 6/2/23 7:19 PM: -------------------------------------------------------------- Fixed in [8ea4160f|https://github.com/apache/calcite/commit/8ea4160f10e95aca6c3b0029d505bbc56975a873]; thanks for the PR, [~ian.bertolacci]! was (Author: julianhyde): Fixed in [8ea4160f10https://github.com/apache/calcite/commit/8ea4160f10e95aca6c3b0029d505bbc56975a873]; thanks for the PR, [~ian.bertolacci]! > Sarg.isComplementedPoints fails with anti-points which are equal under > `compareTo` but not `equals` > --------------------------------------------------------------------------------------------------- > > Key: CALCITE-5722 > URL: https://issues.apache.org/jira/browse/CALCITE-5722 > Project: Calcite > Issue Type: Bug > Affects Versions: 1.34.0 > Reporter: Ian Bertolacci > Assignee: Ian Bertolacci > Priority: Minor > Labels: pull-request-available > Fix For: 1.35.0 > > > Example: > {code:java} > final Sarg<BigDecimal> badComplimentPointsSarg = > Sarg.of( > RexUnknownAs.UNKNOWN, > TreeRangeSet.create( > Arrays.asList( > // Create anti-point around 1, with different scales > Range.lessThan(new BigDecimal("1")), > Range.greaterThan(new BigDecimal("1.00000000000")) > ) > ) > ); > assertThat(badComplimentPointsSarg.isComplementedPoints(), is(true)); > {code} > will fail. > This is because [RangeSets.isPoints uses direct equality and not > `Comparable.compareTo` > equality|https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/util/RangeSets.java#LL132C1-L133C1] > The values {{`1`}} and {{`1.00000000000`}} are not equal under > `BigDecimal.equals` but are equal under `BigDecimal.compareTo`. -- This message was sent by Atlassian Jira (v8.20.10#820010)