[
https://issues.apache.org/jira/browse/CALCITE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735902#comment-17735902
]
Julian Hyde edited comment on CALCITE-5724 at 6/21/23 9:14 PM:
---------------------------------------------------------------
Oh, maybe that wasn't a conflict. In the {{orderField}} method it looks like
you changed something then changed it back.
Still, I'm seeing a failure in {{testBQSelectLiteralGroupByOrdinal}} after I
rebase. Maybe interaction with CALCITE-5510 or CALCITE-5530?
In {{SqlConformanceEnum}}, can you move {{isSortByLiteralAllowed}} so that it
is next to {{isSortByOrdinal}}.
was (Author: julianhyde):
Oh, maybe that wasn't a conflict. In the {{orderField}} method it looks like
you changed something then changed it back.
Still, I'm seeing a failure in {{testBQSelectLiteralGroupByOrdinal}}. Maybe
interaction with CALCITE-5510 or CALCITE-5530?
In {{SqlConformanceEnum}}, can you move {{isSortByLiteralAllowed}} so that it
is next to {{isSortByOrdinal}}.
> Generated SQL uses literal values in ORDER BY clauses
> -----------------------------------------------------
>
> Key: CALCITE-5724
> URL: https://issues.apache.org/jira/browse/CALCITE-5724
> Project: Calcite
> Issue Type: Bug
> Reporter: Joey Moore
> Assignee: Joey Moore
> Priority: Major
> Labels: pull-request-available
>
> Current behavior in the SqlImplementor will generate SqlCharStringLiterals in
> ORDER BY fields when there is a Literal value in the SELECT clause. This
> happens in languages with isSortByOrdinal(). This leads to errors in dialects
> in which cannot have literal values in ORDER BY clauses such as BigQuery.
> Proposed fix is to use ordinals in all cases where a literal value is present
> in the SELECT clause.
> Example of current implementation:
> {code:java}
> select 3.14159265 as pi
> from \"product\"
> order by 1;
> {code}
> Will return
> {code:java}
> SELECT 3.14159265 AS \"PI\"
> FROM \"foodmart\".\"product\"
> ORDER BY '3.14159265'{code}
> Proposed implementation will return :
> {code:java}
> SELECT 3.14159265 AS \"PI\"
> FROM \"foodmart\".\"product\"
> ORDER BY 1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
