[
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736286#comment-17736286
]
Julian Hyde commented on CALCITE-5615:
--------------------------------------
[~mbudiu] Do you have an estimate for how many of the 622 SLT test files
Calcite could run successfully, in their entirety? Would it be 0%, 1%, 10%?,
80%?
Let's suppose it's 1% (6 files). I would add those 6 files to the allow list,
and then figure out which should be files number 7, 8 and 9, and which bugs
need to be fixed in Calcite to make them pass.
I think that tracking the success and failure of individual statements within a
file is probably not worth the effort. I like your idea of recording the number
of failing tests; in addition to detecting regressions if the count increases,
it would also allow us to target the next file to get to 100% passing.
> Run SQLLogicTests using Calcite
> -------------------------------
>
> Key: CALCITE-5615
> URL: https://issues.apache.org/jira/browse/CALCITE-5615
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Sqllogictest is a program designed to verify that an SQL database engine
> computes correct results by comparing the results to identical queries from
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The
> tests only cover the core of SQL, ideally the portable part across all
> engines. They only test integers, doubles, and strings. So they could
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but
> I haven't yet worked out all the details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
