[
https://issues.apache.org/jira/browse/CALCITE-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737053#comment-17737053
]
Akshay Dayal commented on CALCITE-5786:
---------------------------------------
[~julianhyde] Please take a look at
[https://github.com/apache/calcite/pull/3280] - I've closed the previous PR.
I'm not sure about the code smell alert - resources does appear 3 times in the
file - should I go ahead and make it into a constant?
> QuidemTest and DiffRepository have incremental build issues
> -----------------------------------------------------------
>
> Key: CALCITE-5786
> URL: https://issues.apache.org/jira/browse/CALCITE-5786
> Project: Calcite
> Issue Type: Improvement
> Components: build, tests
> Reporter: Akshay Dayal
> Priority: Minor
> Labels: pull-request-available
> Attachments: Screenshot 2023-06-17 at 1.01.29 AM.png, Screenshot
> 2023-06-17 at 6.42.57 PM.png, Screenshot 2023-06-17 at 6.43.20 PM.png
>
>
> QuidemTest and DiffRepository have incremental build issues. The reason is
> that they write output to {{build/resources/test}}.
> The {{test}} tasks treat {{build/resources/test}} as an input, so if there
> are changes made to the directory the {{test}} tasks are considered no longer
> UP-TO-DATE.
> Currently {{QuidemTest}} and {{DiffRepository}}, which are used by tests,
> write to this directory. DiffRepository writes test results to be compared
> with expected results. {{QuidemTest}} creates some sql files which are used
> during testing. This causes issues with incremental build support for the
> {{test}} tasks. I'm attaching screenshots from a build scan to show this.
> Neither of these need to be written to the {{build/resources/test}}
> directory, they can be put somewhere else in the {{build}} directory and
> therefore not cause issues with incremental build support.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
